CB-5839 fix: resource blocking #3199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SychevAndrey
previously approved these changes
Jan 20, 2025
|
The case:
2025-01-21.15.04.36.mov |
sergeyteleshev
requested changes
Jan 21, 2025
Comment on lines
296
to
301
| if (!nodeId.startsWith('database://')) { | ||
| return; | ||
| } | ||
|
|
||
| const indexOfConnectionPart = nodeId.indexOf('/', 11); | ||
| const connectionId = nodeId.slice(11, indexOfConnectionPart > -1 ? indexOfConnectionPart : nodeId.length); |
There was a problem hiding this comment.
lets remove magic numbers and move the key database:// to something like NodeManagerUtils.DatabaseNodeBase
cloudbeaver/webapp/packages/core-navigation-tree/src/NodesManager/NodeManagerUtils.ts
and replace this 11 with its length
devnaumov
previously approved these changes
Jan 22, 2025
|
Also have found this case 2025-01-22.13.46.55.mov |
sergeyteleshev
previously approved these changes
Jan 27, 2025
sergeyteleshev
previously approved these changes
Feb 19, 2025
sergeyteleshev
previously approved these changes
Feb 19, 2025
SychevAndrey
previously approved these changes
Feb 19, 2025
devnaumov
previously approved these changes
Feb 19, 2025
Wroud
dismissed stale reviews from sergeyteleshev, SychevAndrey, and devnaumov
via
9340cd8
sergeyteleshev
approved these changes
Mar 27, 2025
dupen01
pushed a commit
to dupen01/cloudbeaver
that referenced
this pull request
Mar 28, 2025
* CB-5839 fix: resource blocking * CB-5839 fix: unlock nav resources * fix: connections loading * feat: select new folder or connection * chore: localization * chore: revert improvements * fix: load connections list for connection selector * fix: error * fix: wrong action handler * CB-5839 fix: resources tree validation * fix: reaction concurrency * CB-5839 fixes build for new CellFormatter (ObjectMenuCell) after merge conflicts * СB-5839 changes delay for menu item loaders * CB-5839 fix: keys intersection detection in resources * CB-5839 fix: keys intersection detection in resources --------- Co-authored-by: mr-anton-t <[email protected]> Co-authored-by: Daria Marutkina <[email protected]> Co-authored-by: sergeyteleshev <[email protected]> Co-authored-by: Evgenia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.