CB-3798 poc api for visibility of properties #3311
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yagudin10
force-pushed
the
CB-3798-mvp-auth-models-refactoring
branch
from
b520932 to
d6c59c9
Compare
…els-refactoring
…els-refactoring
Wroud
requested changes
Mar 26, 2025
| }) { | ||
| const translate = useTranslate(); | ||
|
|
||
| let readonly = rest.readOnly; |
There was a problem hiding this comment.
It is a strange move with read-only. Let's revert it as it was from props as readOnly, then you can change it if needed (it's not props mutation)
|
|
||
| const UNDEFINED_MAPPER_VALUE = new Array(2).fill(undefined, 1); | ||
| token('undefined', 20, a => (a ? err() : UNDEFINED_MAPPER_VALUE)); | ||
| token('null', 20, a => (a ? err() : UNDEFINED_MAPPER_VALUE)); |
There was a problem hiding this comment.
It is a bit strange that we treat null as an undefined
| import 'subscript/feature/bool.js'; | ||
|
|
||
| const UNDEFINED_MAPPER_VALUE = new Array(2).fill(undefined, 1); | ||
| token('undefined', 20, a => (a ? err() : UNDEFINED_MAPPER_VALUE)); |
There was a problem hiding this comment.
why not use token('undefined', 20, a => a ? err() : [, undefined]) as in original example?
https://github.com/dy/subscript?tab=readme-ov-file#extending
| object: Record<string, any>; | ||
| } | ||
|
|
||
| export function evaluate(expression: string, object: Record<string, any>) { |
HocKu7
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.