CB 6296 Delete row shortcut not working #3340
Open
+94
−106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was noticed that just after the open, onKeyDown event doesn't reach DataGrid, because focus was not in sync with lib. Also fixes CB-6229 since they have the same root problem with encountered bag
sergeyteleshev
approved these changes
Mar 25, 2025
Wroud
requested changes
Mar 26, 2025
| @@ -26,6 +32,7 @@ export interface DataGridProps extends IDataGridCellContext, IDataGridRowContext | |||
| onScroll?: (event: React.UIEvent<HTMLDivElement>) => void; | |||
| onFocus?: (position: ICellPosition) => void; | |||
| onEditorOpen?: (position: ICellPosition) => void; | |||
| onCellKeyDown?: (args: CellKeyDownArgs<IInnerRow>, event: CellKeyboardEvent) => void; | |||
There was a problem hiding this comment.
Base grid API should not expose the inner implementation (or third-party types and API's) as much as possible. Please change type to something like: (cell: ICellPosition, event: React.KeyboardEvent<HTMLDivElement>) => void
Wroud
requested changes
Mar 26, 2025
| useEffect(() => { | ||
| const gridDiv = dataGridDivRef.current; | ||
|
|
||
| handleFocusChange(focusedCell.current ?? { colIdx: 1, rowIdx: 0 }); |
There was a problem hiding this comment.
Isn't it an issue with base grid implementation? We can't use magic numbers here, assuming that there is always at least one column and row (the table can be empty with no rows at all)
There was a problem hiding this comment.
This approach works well with empty tables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5213
CB-6296 Delete row shortcut not working
closes #5178
https://dbeaver.atlassian.net/browse/CB-6229 (see first video)
Value panel fix
Screen.Recording.2025-03-25.at.18.18.02.mov
Delete newly created rows
Screen.Recording.2025-03-25.at.18.17.32.mov
Delete existing rows, cancel on Esc
Screen.Recording.2025-03-25.at.18.17.01.mov