Feature/0257 vehicle data hands off steering #13

dboltovskyi · 2020-07-14T02:34:48Z

Internal review only

…e_data_handsOffSteering

GetmanetsIrina · 2020-07-15T09:29:23Z

test_scripts/API/VehicleData/GetVehicleData/006_GetVD_mandatory_parameters.lua

@@ -0,0 +1,60 @@
+---------------------------------------------------------------------------------------------------
+-- Description: Check that SDL processes GetVehicleData RPC with <vd_param> parameter


Please extend the description and steps with the description of negative case(missing mandatory)

GetmanetsIrina · 2020-07-15T09:35:02Z

...s/API/VehicleData/GetVehicleData/007_GetVD_app_version_is_greater_than_parameter_version.lua

+-- Preconditions:
+-- 1) SDL and HMI are started
+-- 2) Vehicle Data RPCs and <vd_param> parameter are allowed by policies
+-- 3) <vd_param> parameter has param_version = 5.1.0


Propose to remove version numbers and have a description of case like App is registered with syncMsgVersion greater than a version of <vd_param> parameter because different parameters have different versions.

GetmanetsIrina · 2020-07-15T09:35:24Z

...s/API/VehicleData/GetVehicleData/007_GetVD_app_version_is_greater_than_parameter_version.lua

+-- 4) App is registered with syncMsgVersion = 5.1.1
+--
+-- In case:
+-- 1) App send any of Vehicle Data RPC with <vd_param> parameter


Suggested change

-- 1) App send any of Vehicle Data RPC with <vd_param> parameter

-- 1) App sends any of Vehicle Data RPC with <vd_param> parameter

GetmanetsIrina · 2020-07-15T09:35:39Z

...s/API/VehicleData/GetVehicleData/007_GetVD_app_version_is_greater_than_parameter_version.lua

+-- 1) App send any of Vehicle Data RPC with <vd_param> parameter
+-- - a) GetVehicleData, SubscribeVehicleData, UnsubscribeVehicleData
+-- SDL does:
+-- - a) processes this RPC successfully


Suggested change

-- - a) processes this RPC successfully

-- - a) process this RPC successfully

GetmanetsIrina · 2020-07-15T09:35:58Z

...s/API/VehicleData/GetVehicleData/007_GetVD_app_version_is_greater_than_parameter_version.lua

+-- 2) App is subscribed to <vd_param> parameter
+-- 3) HMI sends OnVehicleData notification with <vd_param> parameter
+-- SDL does:
+-- - a) processes this Notification successfully


Suggested change

-- - a) processes this Notification successfully

-- - a) process this Notification successfully

GetmanetsIrina · 2020-07-15T09:46:59Z

...ipts/API/VehicleData/GetVehicleData/008_GetVD_app_version_is_less_than_parameter_version.lua

+-- Preconditions:
+-- 1) SDL and HMI are started
+-- 2) Vehicle Data RPCs and <vd_param> parameter are allowed by policies
+-- 3) <vd_param> parameter has param_version = 5.1.0


https://github.com/dboltovskyi/sdl_atf_test_scripts/pull/13/files#r454921572 the same comment here

GetmanetsIrina · 2020-07-15T09:49:53Z

...s/API/VehicleData/GetVehicleData/007_GetVD_app_version_is_greater_than_parameter_version.lua

+  common.Title("Test")
+  common.Step("RPC " .. common.rpc.get, common.getVehicleData, { param })
+  common.Step("RPC " .. common.rpc.sub, common.processSubscriptionRPC, { common.rpc.sub, param })
+  common.Step("RPC " .. common.rpc.on, common.sendOnVehicleData, { param, 1 })


Please move 1 in a local variable

GetmanetsIrina · 2020-07-15T09:50:14Z

...ipts/API/VehicleData/GetVehicleData/008_GetVD_app_version_is_less_than_parameter_version.lua

+  common.Title("Test")
+  common.Step("RPC " .. common.rpc.get, common.processRPCFailure, { common.rpc.get, param, result })
+  common.Step("RPC " .. common.rpc.sub, common.processRPCFailure, { common.rpc.sub, param, result })
+  common.Step("RPC " .. common.rpc.on, common.sendOnVehicleData, { param, 0 })


https://github.com/dboltovskyi/sdl_atf_test_scripts/pull/13/files#r454930318 the same here

Please perform the same update for all others scripts

GetmanetsIrina · 2020-07-15T10:02:42Z

test_scripts/API/VehicleData/OnVehicleData/005_OnVD_App_is_not_subscribed.lua

+  common.Step("RPC " .. common.rpc.sub, common.processSubscriptionRPC, { common.rpc.sub, param })
+  common.Step("RPC " .. common.rpc.on, common.sendOnVehicleData, { param, 1 })
+  common.Step("RPC " .. common.rpc.unsub, common.processSubscriptionRPC, { common.rpc.unsub, param })
+  common.Step("RPC " .. common.rpc.on, common.sendOnVehicleData, { param, 0 })


maybe this step is redundant, because the notification is also checked in the step below

@GetmanetsIrina There are 2 groups of parameters: subscribable (e.g. gps) and not subscribable (e.g. vin)
Each groups is checked separately since expected result is different.
In 1st group by having sendOnVehicleData, { param, 0 } step we're checking that unsubscription was done successfully.
In 2nd group by having the same step we're checking that was not subscription at all.

GetmanetsIrina · 2020-07-15T10:05:54Z

test_scripts/API/VehicleData/OnVehicleData/006_OnVD_mandatory_parameters.lua

@@ -0,0 +1,43 @@
+---------------------------------------------------------------------------------------------------
+-- Description: Check that SDL processes OnVehicleData notification with <vd_param> parameter
+-- with only mandatory sub-parameters


Please extend the script description with a negative case

GetmanetsIrina · 2020-07-15T10:13:15Z

test_scripts/API/VehicleData/SubscribeVehicleData/006_SubscribeVD_2nd_request_IGNORED.lua

+  common.Step("RPC 2 " .. common.rpc.sub .. " IGNORED", common.processRPCFailure,
+    { common.rpc.sub, param, result })
+end
+for param in common.spairs(common.getVDParams(false)) do


Please add to the description these cases with INVALID_DATA or move them to another script

GetmanetsIrina · 2020-07-15T10:16:50Z

test_scripts/API/VehicleData/SubscribeVehicleData/001_SubscribeVD_Success.lua

+  common.Title("VD parameter: " .. param)
+  common.Step("RPC " .. common.rpc.sub, common.processSubscriptionRPC, { common.rpc.sub, param })
+end
+for param in common.spairs(common.getVDParams(false)) do


Please extend the description with this case, but i propose to move this case to separate scripts because this is not a success case.

GetmanetsIrina · 2020-07-15T10:17:22Z

test_scripts/API/VehicleData/UnsubscribeVehicleData/001_UnsubscribeVD_Success.lua

+  common.Step("RPC " .. common.rpc.unsub, common.processSubscriptionRPC, { common.rpc.unsub, param })
+end
+
+for param in common.spairs(common.getVDParams(false)) do


https://github.com/dboltovskyi/sdl_atf_test_scripts/pull/13/files#r454945564

GetmanetsIrina · 2020-07-15T10:21:58Z

test_scripts/API/VehicleData/UnsubscribeVehicleData/006_UnsubscribeVD_2nd_request_IGNORED.lua

+  common.Step("RPC 2 " .. common.rpc.unsub .. " IGNORED", common.processRPCFailure,
+    { common.rpc.unsub, param, result })
+end
+for param in common.spairs(common.getVDParams(false)) do


https://github.com/dboltovskyi/sdl_atf_test_scripts/pull/13/files#r454943666

GetmanetsIrina · 2020-07-15T11:08:17Z

...s/API/VehicleData/GetVehicleData/007_GetVD_app_version_is_greater_than_parameter_version.lua

@@ -0,0 +1,41 @@
+---------------------------------------------------------------------------------------------------


Script is executed successful but without steps at all, the same to 008_GetVD script

@GetmanetsIrina I have another result. There are steps executed for parameters with version defined, e.g. cloudAppVehicleID, electronicParkBrakeStatus etc.
Have you used appropriate MOBILE/HMI APIs in ATF? For such tests it's important to have correct APIs in ATF ./data folder.

dboltovskyi · 2020-07-15T18:00:19Z

@GetmanetsIrina Please find updates in 852f4a2

GetmanetsIrina and others added 7 commits May 22, 2020 16:00

Initial scripts for new vehicle data HandsOffSteering

24da52e

Add handsOffSteering data in Generic network signal data scripts

559d6f5

Increasing parameter version to 6.2

60a5b6a

fixup! Initial scripts for new vehicle data HandsOffSteering

a58bbb8

Update app version

9b84503

Merge remote-tracking branch 'smart/develop' into feature/0257_vehicl…

22f51e1

…e_data_handsOffSteering

Enable scripts for fixed issue

e500340

dboltovskyi force-pushed the feature/0257_vehicle_data_handsOffSteering branch 2 times, most recently from 602b9af to b252583 Compare July 15, 2020 02:25

GetmanetsIrina reviewed Jul 15, 2020

View reviewed changes

Rework scripts for VechicleData incl handsOffSteering

74719da

dboltovskyi force-pushed the feature/0257_vehicle_data_handsOffSteering branch from 852f4a2 to 74719da Compare July 16, 2020 01:00

		@@ -0,0 +1,60 @@
		---------------------------------------------------------------------------------------------------
		-- Description: Check that SDL processes GetVehicleData RPC with <vd_param> parameter

	-- 1) App send any of Vehicle Data RPC with <vd_param> parameter
	-- 1) App sends any of Vehicle Data RPC with <vd_param> parameter

	-- - a) processes this RPC successfully
	-- - a) process this RPC successfully

	-- - a) processes this Notification successfully
	-- - a) process this Notification successfully

		@@ -0,0 +1,41 @@
		---------------------------------------------------------------------------------------------------

Feature/0257 vehicle data hands off steering #13

Are you sure you want to change the base?

Feature/0257 vehicle data hands off steering #13

Uh oh!

Conversation

dboltovskyi commented Jul 14, 2020

Uh oh!

GetmanetsIrina Jul 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dboltovskyi Jul 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dboltovskyi commented Jul 15, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

GetmanetsIrina Jul 15, 2020 •

edited

Loading

dboltovskyi Jul 15, 2020 •

edited

Loading