-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add null equality condition to equals macro #744
Merged
colin-rogers-dbt
merged 49 commits into
main
from
add_null_equality_condition_to_equals_macro
Feb 4, 2025
Merged
Add null equality condition to equals macro #744
colin-rogers-dbt
merged 49 commits into
main
from
add_null_equality_condition_to_equals_macro
Feb 4, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bt-adapters into fix_null_equality_110
…bt-adapters into fix_null_equality_110
…null_equality_condition_to_equals_macro
colin-rogers-dbt
pushed a commit
that referenced
this pull request
Feb 3, 2025
colin-rogers-dbt
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #110
followup to #383 #394
Note: still needs the athena test skip fix to be merged into main
Problem
We need to add the capability for the
equals
macro to way the presence of no values. However, this is a huge blast radius and doesn't suit all use cases. So we'd like to add it behind a behavior flag and through customer use of this different behavior determine in the future what would be a better long-term solution while also delivering the customer value we need now. A complete solution will require far more investigation outside of this effort.Solution
The equals macro can be configured at the
dbt_project.yml
level. Special attention is given to bigquery tests in this poor request because turning this flag on or off results in many errors across our current tests. This macro does not play well with sophisticated partitioning. A follow on snowflake PR is coming that will make use of this behavior and test it even more thoroughly.Checklist