Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement drop_glue_database macro and method #758

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Implement drop_glue_database macro and method #758

wants to merge 1 commit into from

Conversation

svdimchenko
Copy link
Contributor

Resolves #408

Problem

see the linked issue

Solution

Implement macro drop_glue_database which drops database using AWS Glue API instead of Athena API.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@svdimchenko svdimchenko requested a review from a team as a code owner January 29, 2025 11:19
@cla-bot cla-bot
Copy link

cla-bot bot commented Jan 29, 2025

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @svdimchenko

@svdimchenko svdimchenko mentioned this pull request Jan 29, 2025
Closed
4 tasks
mikealfare added a commit that referenced this pull request Jan 29, 2025
@mikealfare @emmyoop
Add docker release to the full release process for final releases (#758
3b6de5b 
)

* add docker release to release pipeline
* add docker to dependabot
* update to align with other adapters
* update build arg in test
* removed defaulted input for docker package
* add permissions for nightly test release
* account for draft releases not havign docker, allow docker only release
* Update docker/Dockerfile
* pull release-prep into this repo to install aws cli, use env vars, and deal with flaky tests
* remove unused test script

---------

Co-authored-by: Emily Rockman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicor88 nicor88 nicor88 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Implement drop_glue_database macro and method
2 participants
@svdimchenko @nicor88