ADAP-1170: Migrate managed catalog to the new catalog framework #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikealfare
added
pkg:dbt-snowflake
mikealfare
had a problem deploying
to
dbt-postgres
GitHub Actions
Failure
mikealfare
had a problem deploying
to
dbt-snowflake
GitHub Actions
Error
|
Thank you for your pull request! We could not find a changelog entry for this change in the dbt-adapters package. For details on how to document a change, see the Contributing Guide. |
|
Thank you for your pull request! We could not find a changelog entry for this change in the dbt-snowflake package. For details on how to document a change, see the Contributing Guide. |
…_table_as into a switch macro
…_table_as into a switch macro
…inal iceberg table configuration
…inal iceberg table configuration
mikealfare
force-pushed
the
dbt-snowflake/migrate-managed-catalogs
branch
from
f74cc6a to
9b9b37f
Compare
mikealfare
had a problem deploying
to
dbt-snowflake
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to migrate the current Iceberg implementation over to the new catalog framework. The current implementation works off of
table_formatbeing defined in the model config. So if that's there andcatalog_nameis not defined, we need to raise a warning to the user to use the new config (catalog_name = 'snowflake'). In this scenario, we should fallback to the existing DDL. Otherwise, ifcatalog_nameis defined, we should use the new DDL. If neither of these are defined, this is just a standard table.