Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recording only the top layer functions #239

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Conversation

ChenyuLInx
Copy link
Contributor

@ChenyuLInx ChenyuLInx commented Jan 24, 2025

Description

When recorded functions are called (even indirectly) from another recorded function, we only want to record the call uppermost function in the call tree.

Checklist

@ChenyuLInx ChenyuLInx requested a review from a team as a code owner January 24, 2025 04:21
@cla-bot cla-bot bot added the cla:yes label Jan 24, 2025
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.94%. Comparing base (2253401) to head (4ac13fe).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #239      +/-   ##
==========================================
+ Coverage   68.89%   68.94%   +0.05%     
==========================================
  Files          52       52              
  Lines        3433     3439       +6     
==========================================
+ Hits         2365     2371       +6     
  Misses       1068     1068              
Flag Coverage Δ
unit 68.94% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChenyuLInx ChenyuLInx added the Skip Changelog Skips GHA to check for changelog file label Jan 24, 2025
Copy link
Contributor

@peterallenwebb peterallenwebb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@peterallenwebb peterallenwebb added this pull request to the merge queue Jan 24, 2025
Merged via the queue into main with commit e2d8572 Jan 24, 2025
15 of 16 checks passed
@peterallenwebb peterallenwebb deleted the cl/record_multiple_layer branch January 24, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants