Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "invocation_started_at" global field #246

Merged
merged 3 commits into from
Feb 13, 2025
Merged

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Feb 13, 2025

resolves #245

Description

Add new global "invocation_started_at" which is created and reset at the same time as "invocation_id".

Checklist

@gshank gshank requested a review from a team as a code owner February 13, 2025 18:54
@cla-bot cla-bot bot added the cla:yes label Feb 13, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.90%. Comparing base (397fb3f) to head (3d4fbe3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #246      +/-   ##
==========================================
+ Coverage   69.83%   69.90%   +0.07%     
==========================================
  Files          52       52              
  Lines        3517     3522       +5     
==========================================
+ Hits         2456     2462       +6     
+ Misses       1061     1060       -1     
Flag Coverage Δ
unit 69.90% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@QMalcolm
Copy link
Contributor

It might be that this dbt-common way is the better way to be doing this. However, we do already provide an invoked_at in the RuntimeConfig. Whether that changes the necessity of this work in dbt-common, I'm not sure

Copy link
Contributor

@QMalcolm QMalcolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it! We should get dbt-core updated to use this for the setting of invoked_at on the RuntimeConfig.

@gshank gshank added this pull request to the merge queue Feb 13, 2025
Merged via the queue into main with commit 9fcca14 Feb 13, 2025
15 checks passed
@gshank gshank deleted the invocation_started_at branch February 13, 2025 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "invocation_started_at" field next to "invocation_id"
3 participants