Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gate using sample mode with dbt_experimental_sample_mode environment variable #11227

Open
1 task done
Tracked by #11226
QMalcolm opened this issue Jan 22, 2025 · 0 comments
Open
1 task done
Tracked by #11226
Assignees
Labels
enhancement New feature or request sample_mode
Milestone

Comments

@QMalcolm
Copy link
Contributor

QMalcolm commented Jan 22, 2025

Housekeeping

  • I am a maintainer of dbt-core

Short description

During the initial development of sample mode, when the details may change often, we want to gate even being able to use sample mode behind an environment variable dbt_experimental_sample_mode. We want to do this because we don't want anyone depending on sample mode until it is no longer an experimental feature (when we're confident it is no longer going to change dramatically / when 1.10.0 goes GA).

Acceptance criteria

There exists an environment variable which gates all sample mode functionality

Suggested Tests

  • sample mode can be run when the environment variable is set to true
  • sample mode cannot be run when the environment variable is set to false

Impact to Other Teams

N/A

Will backports be required?

No, it's a new feature

Context

N/A

@QMalcolm QMalcolm added the microbatch Issues related to the microbatch incremental strategy label Jan 22, 2025
@QMalcolm QMalcolm added this to the v1.10 milestone Jan 22, 2025
@QMalcolm QMalcolm changed the title gate using sample mode with dbt_experimental_sample_mode environment variable Gate using sample mode with dbt_experimental_sample_mode environment variable Jan 22, 2025
@QMalcolm QMalcolm added sample_mode enhancement New feature or request and removed microbatch Issues related to the microbatch incremental strategy labels Jan 22, 2025
@QMalcolm QMalcolm self-assigned this Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request sample_mode
Projects
None yet
Development

No branches or pull requests

1 participant