-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support passing args
as keyword argument for run-operation
in programmatic invocations
#10473
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your patch check has failed because the patch coverage (25.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #10473 +/- ##
==========================================
- Coverage 88.86% 88.80% -0.06%
==========================================
Files 180 180
Lines 22560 22573 +13
==========================================
Hits 20047 20047
- Misses 2513 2526 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…programmatic invocations
--args
for run-operation
in programmatic invocationsargs
as keyword argument for run-operation
in programmatic invocations
This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days. |
resolves #10355
Problem
As described in #10355, there's a naming conflict between the first parameter of
dbtRunner.invoke()
and the--args
CLI flag of therun-operation
command.Solution
args
toinvocation_args
run_dbt
andrun_dbt_and_capture
test utilities to take optionalkwargs
parameters for testing purposesInterface changes
These interface changes assume that the intended and dominant usage of
dbtRunner.invoke
is a positional first argument along with optional kwargs:dbtRunner.invoke
renameargs
toinvocation_args
and explicitly make it positionalrun_dbt
andrun_dbt_and_capture
with those same changesIf anyone has code like
dbtRunner().invoke(args=["run", ...])
they would need to update it by removingargs=
.Testing strategy
Indirectly testing
dbtRunner().invoke()
viarun_dbt_and_capture
&run_dbt
-- added this new test to verify that customargs
makes it through:Checklist