-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add doc_blocks
to manifest for nodes and columns
#11224
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11224 +/- ##
==========================================
- Coverage 88.93% 88.87% -0.06%
==========================================
Files 187 187
Lines 24049 24072 +23
==========================================
+ Hits 21388 21395 +7
- Misses 2661 2677 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
|
doc_blocks
to manifest for nodes and columnsdoc_blocks
to manifest for nodes and columns
Resolves #11000
Resolves #11001
Problem
doc_blocks
are not listed for node/column descriptions, so it's not possible to know if a description was created via literal or via doc block.Solution
Add a new field
doc_blocks
for node and column descriptions that is present in the manifest.doc_blocks
is a list of unique IDs that can be accessed like so:I'll also update
schemas.getdbt.com
once this PR is approved to fix schema check errors below.Checklist