-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADAP-1135: Point to the dbt-adapters
subdirectory for tests post-monorepo migration
#11244
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be backported to 1.7 and 1.8.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11244 +/- ##
=======================================
Coverage 88.86% 88.86%
=======================================
Files 187 187
Lines 24049 24049
=======================================
Hits 21371 21371
Misses 2678 2678
Flags with carried forward coverage won't be shown. Click here to find out more.
|
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.8.latest 1.8.latest
# Navigate to the new working tree
cd .worktrees/backport-1.8.latest
# Create a new branch
git switch --create backport-11244-to-1.8.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 48d9afa677eee6dcc1bbab6b6e9fa654fdf862b6
# Push it to GitHub
git push --set-upstream origin backport-11244-to-1.8.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.8.latest Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.7.latest 1.7.latest
# Navigate to the new working tree
cd .worktrees/backport-1.7.latest
# Create a new branch
git switch --create backport-11244-to-1.7.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 48d9afa677eee6dcc1bbab6b6e9fa654fdf862b6
# Push it to GitHub
git push --set-upstream origin backport-11244-to-1.7.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.7.latest Then, create a pull request where the |
(cherry picked from commit 48d9afa)
(cherry picked from commit 48d9afa)
… (#11245) (cherry picked from commit 48d9afa) Co-authored-by: Mike Alfare <[email protected]>
Problem
The
dbt-adapters
package moved into a subdirectory in thedbt-adapters
repo. The development dependencies assume this package is at the root.Solution
dev-requirements.txt
to point to the subdirectoryWarning
This PR will need to be backported to any minor release branches which install
dbt-adapters
directly from GitHub.Checklist