Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADAP-1135: Point to the dbt-adapters subdirectory for tests post-monorepo migration #11244

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

mikealfare
Copy link
Contributor

Problem

The dbt-adapters package moved into a subdirectory in the dbt-adapters repo. The development dependencies assume this package is at the root.

Solution

  • update dev-requirements.txt to point to the subdirectory

Warning

This PR will need to be backported to any minor release branches which install dbt-adapters directly from GitHub.

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@mikealfare mikealfare added the Skip Changelog Skips GHA to check for changelog file label Jan 27, 2025
@mikealfare mikealfare self-assigned this Jan 27, 2025
@mikealfare mikealfare requested a review from a team as a code owner January 27, 2025 19:34
@cla-bot cla-bot bot added the cla:yes label Jan 27, 2025
Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be backported to 1.7 and 1.8.

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.86%. Comparing base (cb323ef) to head (4aa2527).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11244   +/-   ##
=======================================
  Coverage   88.86%   88.86%           
=======================================
  Files         187      187           
  Lines       24049    24049           
=======================================
  Hits        21371    21371           
  Misses       2678     2678           
Flag Coverage Δ
integration 86.17% <ø> (ø)
unit 62.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.47% <ø> (ø)
Integration Tests 86.17% <ø> (ø)

@mikealfare mikealfare merged commit 48d9afa into main Jan 28, 2025
78 checks passed
@mikealfare mikealfare deleted the update-dev-deps-for-adapters-monorepo branch January 28, 2025 00:01
Copy link
Contributor

The backport to 1.8.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.8.latest 1.8.latest
# Navigate to the new working tree
cd .worktrees/backport-1.8.latest
# Create a new branch
git switch --create backport-11244-to-1.8.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 48d9afa677eee6dcc1bbab6b6e9fa654fdf862b6
# Push it to GitHub
git push --set-upstream origin backport-11244-to-1.8.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.8.latest

Then, create a pull request where the base branch is 1.8.latest and the compare/head branch is backport-11244-to-1.8.latest.

Copy link
Contributor

The backport to 1.7.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.7.latest 1.7.latest
# Navigate to the new working tree
cd .worktrees/backport-1.7.latest
# Create a new branch
git switch --create backport-11244-to-1.7.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 48d9afa677eee6dcc1bbab6b6e9fa654fdf862b6
# Push it to GitHub
git push --set-upstream origin backport-11244-to-1.7.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.7.latest

Then, create a pull request where the base branch is 1.7.latest and the compare/head branch is backport-11244-to-1.7.latest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants