Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loosen validation for freshness #11253

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Conversation

ChenyuLInx
Copy link
Contributor

Resolves #11123

Problem

We are having too strict of a validation for freshness

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@ChenyuLInx ChenyuLInx requested a review from a team as a code owner January 28, 2025 21:57
@cla-bot cla-bot bot added the cla:yes label Jan 28, 2025
@ChenyuLInx ChenyuLInx added the artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking label Jan 28, 2025
@ChenyuLInx ChenyuLInx merged commit c042370 into main Jan 28, 2025
58 of 63 checks passed
@ChenyuLInx ChenyuLInx deleted the cl/make-model-freshness-extensible branch January 28, 2025 22:20
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.89%. Comparing base (48d9afa) to head (7d6cffd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11253      +/-   ##
==========================================
- Coverage   88.92%   88.89%   -0.04%     
==========================================
  Files         187      187              
  Lines       24072    24072              
==========================================
- Hits        21406    21398       -8     
- Misses       2666     2674       +8     
Flag Coverage Δ
integration 86.20% <100.00%> (-0.12%) ⬇️
unit 62.44% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.44% <100.00%> (ø)
Integration Tests 86.20% <100.00%> (-0.12%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking cla:yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Adaptive Job] Add freshness spec to model
2 participants