Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require 2 CODEOWNER reviews for artifact changes #11256

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Jan 29, 2025

Problem

Let's ensure artifact and validation changes include 2 core reviews. GitHub doesn't allow this in a built in way so we'll use a required workflow.

Solution

Check number of reviews in a workflow
Require workflow to pass before PR can be merged

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@cla-bot cla-bot bot added the cla:yes label Jan 29, 2025
@emmyoop emmyoop changed the title first pass Require 2 CODEOWNER reviews for artifact changes Jan 29, 2025
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.92%. Comparing base (c042370) to head (4313c32).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11256      +/-   ##
==========================================
+ Coverage   88.87%   88.92%   +0.04%     
==========================================
  Files         187      187              
  Lines       24072    24072              
==========================================
+ Hits        21395    21406      +11     
+ Misses       2677     2666      -11     
Flag Coverage Δ
integration 86.30% <ø> (+0.11%) ⬆️
unit 62.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.44% <ø> (ø)
Integration Tests 86.30% <ø> (+0.11%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant