Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

post-hoc addition of discussion to roadmap #11259

Merged
merged 1 commit into from
Jan 30, 2025
Merged

post-hoc addition of discussion to roadmap #11259

merged 1 commit into from
Jan 30, 2025

Conversation

dataders
Copy link
Contributor

Resolves #

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@cla-bot cla-bot bot added the cla:yes label Jan 29, 2025
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.87%. Comparing base (c042370) to head (4699c49).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11259   +/-   ##
=======================================
  Coverage   88.87%   88.87%           
=======================================
  Files         187      187           
  Lines       24072    24072           
=======================================
  Hits        21395    21395           
  Misses       2677     2677           
Flag Coverage Δ
integration 86.19% <ø> (ø)
unit 62.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.44% <ø> (ø)
Integration Tests 86.19% <ø> (ø)

Copy link
Contributor

@QMalcolm QMalcolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@dataders dataders marked this pull request as ready for review January 29, 2025 19:49
@dataders dataders requested a review from a team as a code owner January 29, 2025 19:49
@dataders dataders added the Skip Changelog Skips GHA to check for changelog file label Jan 29, 2025
@dataders dataders changed the title post-hoc addition of roadmap post-hoc addition of discussion to roadmap Jan 29, 2025
@QMalcolm QMalcolm merged commit fdabe95 into main Jan 30, 2025
60 checks passed
@QMalcolm QMalcolm deleted the dataders-patch-1 branch January 30, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants