Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update depends_on default #11276

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

update depends_on default #11276

wants to merge 1 commit into from

Conversation

mirnawong1
Copy link
Contributor

@mirnawong1 mirnawong1 commented Feb 5, 2025

per internal slack thread with @ChenyuLInx and @gshank , the default for the depends_on value is all , not any.

@gshank raised that this code has the default to 'any`, which needs to be corrected.

Resolves #

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

per [internal slack thread](https://dbt-labs.slack.com/archives/C05FWBP9X1U/p1738605491997089?thread_ts=1738604102.780369&cid=C05FWBP9X1U) with @ChenyuLInx and @gshank , the default for the `depends_on` value is `all` , not `any`. 

@gshank raised that this code has the default to 'any`, which needs to be corrected.
@mirnawong1 mirnawong1 requested a review from a team as a code owner February 5, 2025 10:14
@cla-bot cla-bot bot added the cla:yes label Feb 5, 2025
Copy link
Contributor

github-actions bot commented Feb 5, 2025

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@github-actions github-actions bot added the community This PR is from a community member label Feb 5, 2025
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.28%. Comparing base (5f873da) to head (f3da8de).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11276      +/-   ##
==========================================
- Coverage   88.90%   86.28%   -2.63%     
==========================================
  Files         189      189              
  Lines       24161    24161              
==========================================
- Hits        21481    20847     -634     
- Misses       2680     3314     +634     
Flag Coverage Δ
integration 86.28% <100.00%> (+0.11%) ⬆️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 86.28% <100.00%> (-2.63%) ⬇️
Integration Tests 86.28% <100.00%> (+0.11%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes community This PR is from a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant