Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace MacroResolver with MacroClient #9253

Closed

Conversation

MichelleArk
Copy link
Contributor

resolves #

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label Dec 7, 2023
Copy link
Contributor

github-actions bot commented Dec 7, 2023

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (bb12375) 86.57% compared to head (8973f99) 84.20%.
Report is 14 commits behind head on adapters-macro-context-generator.

❗ Current head 8973f99 differs from pull request most recent head d16988c. Consider uploading reports for the commit d16988c to get more accurate results

Files Patch % Lines
core/dbt/adapters/base/impl.py 75.00% 4 Missing ⚠️
core/dbt/adapters/contracts/macros.py 75.00% 1 Missing ⚠️
core/dbt/parser/manifest.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@                         Coverage Diff                          @@
##           adapters-macro-context-generator    #9253      +/-   ##
====================================================================
- Coverage                             86.57%   84.20%   -2.37%     
====================================================================
  Files                                   220      220              
  Lines                                 26916    26915       -1     
====================================================================
- Hits                                  23302    22664     -638     
- Misses                                 3614     4251     +637     
Flag Coverage Δ
integration 80.62% <86.36%> (-2.83%) ⬇️
unit 65.29% <70.45%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichelleArk MichelleArk force-pushed the adapters-macro-client branch from 4f498f9 to cdf76eb Compare December 7, 2023 16:30
@MichelleArk MichelleArk force-pushed the adapters-macro-client branch from cdf76eb to 8973f99 Compare December 7, 2023 16:40
Base automatically changed from adapters-macro-context-generator to feature/decouple-adapters-from-core December 11, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant