/* PR_START p--sql-updates 04 */ Remove SqlSubQueryReducer.

dbt-labs · Jan 22, 2025 · 9d207ac · 9d207ac
1 parent 6f6b5bf
commit 9d207ac
Show file tree

Hide file tree

Showing 9 changed files with 1 addition and 645 deletions.
diff --git a/metricflow/sql/optimizer/optimization_levels.py b/metricflow/sql/optimizer/optimization_levels.py
@@ -10,7 +10,6 @@
 from metricflow.sql.optimizer.column_pruner import SqlColumnPrunerOptimizer
 from metricflow.sql.optimizer.rewriting_sub_query_reducer import SqlRewritingSubQueryReducer
 from metricflow.sql.optimizer.sql_query_plan_optimizer import SqlPlanOptimizer
-from metricflow.sql.optimizer.sub_query_reducer import SqlSubQueryReducer
 from metricflow.sql.optimizer.table_alias_simplifier import SqlTableAliasSimplifier
 
 
@@ -58,7 +57,7 @@ def options_for_level(  # noqa: D102
         elif level is SqlOptimizationLevel.O2:
             optimizers = (SqlColumnPrunerOptimizer(), SqlTableAliasSimplifier())
         elif level is SqlOptimizationLevel.O3:
-            optimizers = (SqlColumnPrunerOptimizer(), SqlSubQueryReducer(), SqlTableAliasSimplifier())
+            optimizers = (SqlColumnPrunerOptimizer(), SqlTableAliasSimplifier())
         elif level is SqlOptimizationLevel.O4:
             optimizers = (
                 SqlColumnPrunerOptimizer(),

diff --git a/metricflow/sql/optimizer/sub_query_reducer.py b/metricflow/sql/optimizer/sub_query_reducer.py
diff --git a/...sub_query_reducer.py/SqlPlan/test_distinct_select_node_is_not_reduced__after_reducing.sql b/...sub_query_reducer.py/SqlPlan/test_distinct_select_node_is_not_reduced__after_reducing.sql
diff --git a/...ub_query_reducer.py/SqlPlan/test_distinct_select_node_is_not_reduced__before_reducing.sql b/...ub_query_reducer.py/SqlPlan/test_distinct_select_node_is_not_reduced__before_reducing.sql
diff --git a/...low/snapshots/test_sub_query_reducer.py/SqlPlan/test_reduce_sub_query__after_reducing.sql b/...low/snapshots/test_sub_query_reducer.py/SqlPlan/test_reduce_sub_query__after_reducing.sql
diff --git a/...ow/snapshots/test_sub_query_reducer.py/SqlPlan/test_reduce_sub_query__before_reducing.sql b/...ow/snapshots/test_sub_query_reducer.py/SqlPlan/test_reduce_sub_query__before_reducing.sql
diff --git a/..._query_reducer.py/SqlPlan/test_rewrite_order_by_with_a_join_in_parent__after_reducing.sql b/..._query_reducer.py/SqlPlan/test_rewrite_order_by_with_a_join_in_parent__after_reducing.sql
diff --git a/...query_reducer.py/SqlPlan/test_rewrite_order_by_with_a_join_in_parent__before_reducing.sql b/...query_reducer.py/SqlPlan/test_rewrite_order_by_with_a_join_in_parent__before_reducing.sql