-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom offset window: support grains smaller than base grain #1663
base: main
Are you sure you want to change the base?
Conversation
9b6c2f4
to
f44b6dc
Compare
…GrainNode This reflects the change in behavior from this PR.
2b6745f
to
3b64854
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still getting familiar with the changes - can you elaborate on why joining the 2nd time spine is needed for the smaller grain vs. starting out with the smaller grain time spine?
@plypaul yes! So for all standard grains, we can pick the smallest grain and use the time spine that satisfies that, and then just |
Support for querying a custom offset window metric with a grain that's smaller than the custom grain's base grain. Previously this would render invalid SQL.