More tests for custom grain #1664
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
courtneyholcomb
added
Skip Changelog
Run Tests With Other SQL Engines
courtneyholcomb
requested a deployment
to
DW_INTEGRATION_TESTS
GitHub Actions
Waiting
courtneyholcomb
requested a deployment
to
DW_INTEGRATION_TESTS
GitHub Actions
Waiting
courtneyholcomb
requested a deployment
to
DW_INTEGRATION_TESTS
GitHub Actions
Waiting
courtneyholcomb
requested a deployment
to
DW_INTEGRATION_TESTS
GitHub Actions
Waiting
courtneyholcomb
added
Run Tests With Other SQL Engines
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Active
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
github-actions
bot
removed
the
Run Tests With Other SQL Engines
WilliamDee
approved these changes
Feb 7, 2025
| @@ -881,3 +881,12 @@ metric: | |||
| offset_window: 1 alien_day | |||
| alias: bookings_offset | |||
| - name: bookings | |||
| --- | |||
There was a problem hiding this comment.
Small nit to remove extra +---
courtneyholcomb
force-pushed
the
court/custom-offset10
branch
from
2b6745f to
3b64854
Compare
courtneyholcomb
force-pushed
the
court/custom-offset11
branch
from
ad8d233 to
1152cf1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had some random follow up tasks to add tests for specific scenarios, and some simple ones are covered here.