Update handling for Pydantic objects in mf_pformat
#1666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| remaining_line_width=remaining_line_width, | ||
| ) | ||
| # For Pydantic-like objects with a `dict` method that returns field keys / values. | ||
| dict_method = getattr(obj, "dict", None) |
There was a problem hiding this comment.
@plypaul isn't there a chance that it breaks with pydantic v2 where dict was deprecated in favor of model_dump ?
There was a problem hiding this comment.
It actually still works, though now I see the deprecation warning. Updated the case handling though.
There was a problem hiding this comment.
Also to provide context on these formatting methods - in case there's a problem formatting, it falls back to the standard pretty printer or str(...).
courtneyholcomb
approved these changes
Feb 10, 2025
WilliamDee
approved these changes
Feb 10, 2025
thiagosalvatore
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the handling for Pydantic objects in
mf_pformatto check if thedict()methods exists instead of theisinstance(BaseModel)check. TheBaseModelis actually from thedsi_shimand in some cases with different Pydantic versions, it's possible that the check does not pass. Since it's not foolproof, the formatter falls back topprintif there is an error.