Enhance .gitignore, improve ci steps #115
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rooooooooob
reviewed
Nov 16, 2022
.gitignore
Outdated
| # Rust | ||
| target/ | ||
| book/ | ||
| Cargo.lock |
There was a problem hiding this comment.
I thought this should only be ignored for libraries, not applications?
* Improve formatting * Fix formatting
gostkin
force-pushed
the
egostkin/ci-beauty
branch
from
130150d to
9f3a424
Compare
|
Is there anything missing to get merged or what is the state? |
|
@SimonIT Far too many conflicts to merge this. We should wait until all other open PRs are merged before attempting rustfmt again. |
|
Depending on what we want to do with #112 , now may be a good time to reattempt rustfmt |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
idea files are ignored
added commented fmt and clippy steps