Fix compatibility with Windows #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced the usage of tempfile's NamedTemporaryFile() method with the mkstemp() method for the generation of the temp rclone config. The new method requires manual removal of the file but allows the wrapper to work on Windows.
In general, rclone may attempt to update a config file and fail if it cannot do so. With this change, the file descriptor returned by mkstemp() is closed before invoking rclone.
|
This would be very useful. Thanks alot! |
|
Looks like his commit doesn't reflect in the main repository? |
Author
Hi @mohdsabahat, apologies I couldn't respond earlier. This is an unmerged pull request, but if you want to use it you could use the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the usage of tempfile's NamedTemporaryFile() method with the mkstemp() method for the generation of the temp rclone config. This method requires the wrapper to remove the file manually but allows it to work on Windows.
This fixes #4.