This repository was archived by the owner on May 26, 2025. It is now read-only.
Added notContainSubset option to assert#71
Open
diego3g wants to merge 2 commits intodebitoor:masterfrom
diego3g:assert-not
Open
Added notContainSubset option to assert#71diego3g wants to merge 2 commits intodebitoor:masterfrom diego3g:assert-not
diego3g wants to merge 2 commits intodebitoor:masterfrom
diego3g:assert-not
Conversation
Author
|
Any updated on this? |
Contributor
|
@diego3g you can just use chain method |
Author
|
AdonisJS uses I can only use it like this: assert.containSubset(obj, { find: true });And can't use like this: expect(obj).to.containSubset({ find: true })So when i use: assert.not.containSubset(...)It returns: Do you think it's better to change something in Adonis? Actually i don't think it will bring downsides to chai-subset at all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chai assert style generally includes an
notversion for every type of assertion (http://www.chaijs.com/api/assert/#method_notequal).This PR includes the
notContainSubsetoption to assert style.Also runned prettier inside tests to respect ESLint rules.