Trial render bulk polygons #276
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for reactol failed.
|
There was a problem hiding this comment.
PR Overview
This PR introduces a trial implementation for rendering a large body of polygons by adding support for multi-zone features. Key changes include:
- Creation of a new MultiZone component to render multi-polygon features.
- Addition of a loader (loadRepPolygon) to parse and convert polygon data from .rep files into GeoJSON features.
- Updates to document loading, constants, layers, types, and the map component to support multi-zone functionality.
Reviewed Changes
| File | Description |
|---|---|
| src/components/spatial/MultiZone/index.tsx | New component for rendering multi-polygon zones. |
| src/helpers/loaders/loadRepPolygon.ts | New loader for parsing polygon data from .rep files and creating a feature. |
| src/components/Document/index.tsx | Added new file handler support for rep polygon files. |
| src/constants.ts | Introduced MULTI_ZONE_TYPE constant. |
| src/components/Layers/index.tsx | Integrated Multi Zones into the layers panel with a new icon. |
| src/types.ts | Added MultiZoneProps type for multi-zone features. |
| src/components/spatial/Map/index.tsx | Updated map to render MultiZone features based on GeoJSON MultiPolygon. |
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
| const points: Array<{lat: number, lng: number}> = [] | ||
|
|
||
| // Process 5 coordinate pairs | ||
| for (let i = 0; i < 6; i++) { |
There was a problem hiding this comment.
The loop is set to iterate 6 times to process coordinate pairs, but earlier comments and a parts length check suggest processing 5 coordinate pairs. Adjust the loop condition to 'i < 5' or update the parts length validation to ensure consistency.
Suggested change
| for (let i = 0; i < 6; i++) { | |
| for (let i = 0; i < 5; i++) { |
# Conflicts: # src/components/Document/index.tsx # src/types.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trial displaying large body of polygons