Skip to content

[deckhouse-cli] remove tmp directory after d8 mirror pull #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

[deckhouse-cli] remove tmp directory after d8 mirror pull #183

wants to merge 19 commits into from

Conversation

brileyyyy
Copy link
Contributor

@brileyyyy brileyyyy commented Oct 14, 2025 •
edited
Loading

Problem

The d8 mirror pull command creates a .tmp directory during execution but fails to clean it up.

Solution

Added a defer cleanup function at the beginning of the pull() function to guarantee temporary directory removal.

Key improvements:

  • Uses defer for guaranteed cleanup
  • Removes entire .tmp directory
  • Uses warning logging instead of returning errors

Testing

Scenario Result
Normal pull .tmp removed
Pull with --gost-digest .tmp removed
Pull with auth error No .tmp created
Pull with non-existent module No .tmp created

@brileyyyy brileyyyy self-assigned this Oct 14, 2025
@brileyyyy brileyyyy marked this pull request as ready for review October 14, 2025 12:40
ldmonster
ldmonster requested changes Oct 14, 2025
View reviewed changes
Copy link
Collaborator

@ldmonster ldmonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

youn ignore flag tmp-dir.

deckhouse-cli/internal/mirror/cmd/pull/flags.go

Line 166 in 33b7f52

&TempDir,

@brileyyyy brileyyyy requested a review from ldmonster October 15, 2025 08:59
ldmonster
ldmonster previously approved these changes Oct 20, 2025
View reviewed changes
@brileyyyy brileyyyy marked this pull request as draft October 20, 2025 08:53
ldmonster and others added 16 commits October 20, 2025 12:10
@ldmonster @brileyyyy
Signed release channels
2773b87 
Signed-off-by: kerimov <[email protected]>
@ldmonster @brileyyyy
[deckhouse-cli] feat: add plugins architecture (#176)
9439049 
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: kerimov <[email protected]>
@mvasl @brileyyyy
mirror: do not pull security databases for editions where they are no…
ac58b85 
…t present (#178)

Signed-off-by: Maxim Vasilenko <[email protected]>
Signed-off-by: Maxim Vasilenko <[email protected]>
Signed-off-by: kerimov <[email protected]>
@pabateman @ldmonster @brileyyyy
k8s-client: use Precedence in NewNonInteractiveDeferredLoadingClientC…
987329a 
…onfig in case of multiple kubeconfigs (#179)

Signed-off-by: Alexey Voronov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Co-authored-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: kerimov <[email protected]>
@ldmonster @brileyyyy
[deckhouse-cli] lint revive (#187)
fdf72ad 
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: kerimov <[email protected]>
@ldmonster @brileyyyy
[deckhouse-cli] fix/lint revive (#188)
980a614 
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: kerimov <[email protected]>
@RottenRat @brileyyyy
[trdl] d8 v0.20.8 for trdl channels (#189)
cfcb200 
Signed-off-by: Sinelnikov Michail <[email protected]>
Co-authored-by: Sinelnikov Michail <[email protected]>
Signed-off-by: kerimov <[email protected]>
@RottenRat @brileyyyy
Add version before start on d8 mirror pull|push command (#190)
478e742 
Signed-off-by: Sinelnikov Michail <[email protected]>
Co-authored-by: Sinelnikov Michail <[email protected]>
Signed-off-by: kerimov <[email protected]>
@ldmonster @brileyyyy
[deckhouse-cli] feat/rollback revive (#192)
e55ac9e 
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: kerimov <[email protected]>
@ldmonster @brileyyyy
Signed release channels
afb02d7 
Signed-off-by: kerimov <[email protected]>
@ldmonster @RottenRat @brileyyyy
[deckhouse-cli] feat/mirror pull logic refactor (#194)
e8886b5 
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Sinelnikov Michail <[email protected]>
Co-authored-by: Michail Sinelnikov <[email protected]>
Co-authored-by: Sinelnikov Michail <[email protected]>
Signed-off-by: kerimov <[email protected]>
@ldmonster @brileyyyy
[deckhouse-cli] Installation readme (#195)
1ef2859 
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: kerimov <[email protected]>
@brileyyyy
[deckhouse-cli] incorrect push operation for extra images (#182)
e30ee34 
Signed-off-by: kerimov <[email protected]>
@brileyyyy
[deckhouse-cli] remove tmp dir in all cases
c7ae07a 
Signed-off-by: kerimov <[email protected]>
@brileyyyy
[deckhouse-cli] handle custom tmp directory
8860b5a 
Signed-off-by: kerimov <[email protected]>
@brileyyyy
[deckhouse-cli] adapt tmp removing for a new arhictecture
90eb8b5 
Signed-off-by: kerimov <[email protected]>
@brileyyyy brileyyyy force-pushed the feat/tmp-dir-pull-removing branch from 09b1000 to 90eb8b5 Compare October 20, 2025 09:12
@brileyyyy brileyyyy marked this pull request as ready for review October 20, 2025 11:12
@brileyyyy brileyyyy requested a review from ldmonster October 20, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yalosev yalosev Awaiting requested review from yalosev yalosev is a code owner

@ldmonster ldmonster Awaiting requested review from ldmonster ldmonster is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@brileyyyy brileyyyy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@brileyyyy @ldmonster @mvasl @pabateman @RottenRat