[deckhouse-cli] handle non-existing release channels #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kerimov <[email protected]>
ldmonster
reviewed
Oct 20, 2025
| if err != nil { | ||
| // If release channel doesn't exist, don't return an error | ||
| if errorutil.IsImageNotFoundError(err) { | ||
| return nil, nil |
There was a problem hiding this comment.
are we sure about it?
looks like a place for bug possibility
Signed-off-by: kerimov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The d8 mirror tool was failing when trying to pull from registries that included LTS (Long Term Support) release channels. The error occurred during platform version discovery:
get lts from registry: get lts release channel data: GET .../release-channel/manifests/lts: MANIFEST_UNKNOWN: manifest unknown; map[Tag:lts]Root Cause
Hard-coded assumption about channel availability: The code expected all channels to exist in the registry and failed hard when LTS manifests were not found.
Solution