Skip to content

Conversation

diafour
Copy link
Member

@diafour diafour commented Oct 6, 2025

Description

  • Rename more containers for checkings in strict environment.
  • Fix container names in recording rules.
  • Add readonlyRootFilesystem=true for install strategy Jobs in kubevirt.

Why do we need it, and what problem does it solve?

Support RO root Filesystem in strict environments.

A backport of #1536.
Notes:

  • No update for 1.0 release, it is 1.0-cse only.
  • 3p-cdi base is v1.63.0-v12n.10 (start branch v1.63.0-virtualization-1.0-cse, add tag v1.63.0-v12n.10-cse.0) Diff
  • 3p-kubevirt base is v1.3.1-v12n.12 (start branch v1.3.1-virtualization-1.0-cse, add tag v1.3.1-v12n.12-cse.0) Diff

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

@diafour diafour requested review from fl64 and Isteb4k as code owners October 6, 2025 19:27
Copy link
Contributor

sourcery-ai bot commented Oct 6, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR standardizes container naming with a new d8v prefix, updates third-party version tags, corrects references in recording rules, and enforces a read-only root filesystem on KubeVirt install jobs.

Class diagram for container version configuration changes

classDiagram
  class Core {
    +3p-kubevirt: string
    +3p-containerized-data-importer: string
    +distribution: string
  }
  Core : 3p-kubevirt = "v1.3.1-virtualization-1.0-cse"
  Core : 3p-containerized-data-importer = "dvp/chore/more-d8v-prefixed-containers"
  Core : distribution = "2.8.3"
Loading

File-Level Changes

Change Details Files
Add d8v prefix to container names for strict-env compliance
  • Renamed container definitions to include d8v prefix
  • Updated strict-environment checking logic to match new names
  • Adjusted related labels and annotations
manifests/containers.yaml
pkg/validation/strict_env.go
Fix container name references in recording rules
  • Corrected container identifiers in rule matchers
  • Updated recording rule labels to new naming scheme
monitoring/recording_rules.yaml
Enforce readOnlyRootFilesystem on KubeVirt install Jobs
  • Set securityContext.readOnlyRootFilesystem=true in job spec
  • Added missing securityContext block to install strategy job
deploy/kubevirt/install-job.yaml
Bump 3p-kubevirt and CDI component versions to use new tags
  • Commented out old version entries
  • Added updated version strings in build/components/versions.yml
build/components/versions.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

- Rename more containers for checkings in strict environment.
- Fix container names in recording rules.
- Add readonlyRootFilesystem=true for install strategy Jobs in kubevirt.

Signed-off-by: Ivan Mikheykin <[email protected]>
@diafour diafour force-pushed the chore/core/updates-to-support-ro-root-filesystem branch from 7943a22 to de8e72b Compare October 7, 2025 07:18
@diafour diafour changed the title chore(core): add d8v prefix for more containers Backport: chore(core): add d8v prefix for more containers Oct 7, 2025
@diafour diafour merged commit a0f2dc3 into release-1.0-cse Oct 7, 2025
40 of 45 checks passed
@diafour diafour deleted the chore/core/updates-to-support-ro-root-filesystem branch October 7, 2025 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants