-
Notifications
You must be signed in to change notification settings - Fork 2
[cse] fixed path to source code #1551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Aleksey Gavrilov <[email protected]>
Reviewer's GuideThis PR refactors werf build configurations by normalizing source code paths to Flow diagram for normalized source code path during buildflowchart TD
A["Git clone source code to /src"] --> B["Import /src into build images"]
B --> C["Run install scripts from /src"]
C --> D["Final image contains code from /src"]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `images/hooks/werf.inc.yaml:10` </location>
<code_context>
- - go.sum
- setup:
- - "**/*.go"
+ - "**/*"
- add: {{ .ModuleDir }}/images/virtualization-artifact
- to: /app/images/virtualization-artifact
</code_context>
<issue_to_address>
**suggestion (performance):** Broadening stageDependencies to all files may introduce unnecessary rebuilds.
Using "**/*" will trigger rebuilds for any file change, including non-source files, which may slow down builds and reduce cache efficiency. Consider if a narrower pattern would be more appropriate.
Suggested implementation:
```
stageDependencies:
install:
- "**/*.go"
- go.sum
```
```
stageDependencies:
install:
- "**/*.go"
- go.sum
```
</issue_to_address>
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
- go.sum | ||
setup: | ||
- "**/*.go" | ||
- "**/*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (performance): Broadening stageDependencies to all files may introduce unnecessary rebuilds.
Using "**/*" will trigger rebuilds for any file change, including non-source files, which may slow down builds and reduce cache efficiency. Consider if a narrower pattern would be more appropriate.
Suggested implementation:
stageDependencies:
install:
- "**/*.go"
- go.sum
stageDependencies:
install:
- "**/*.go"
- go.sum
Description
Sources in src-artifact should be in /src (cse requirements)
Why do we need it, and what problem does it solve?
What is the expected result?
Checklist
Changelog entries