Skip to content

Conversation

alexey-gavrilov-flant
Copy link
Member

@alexey-gavrilov-flant alexey-gavrilov-flant commented Oct 9, 2025

Description

Sources in src-artifact should be in /src (cse requirements)

Why do we need it, and what problem does it solve?

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: core
type: fix
summary: fixing paths to source code
impact_level: low

Signed-off-by: Aleksey Gavrilov <[email protected]>
Copy link
Contributor

sourcery-ai bot commented Oct 9, 2025

Reviewer's Guide

This PR refactors werf build configurations by normalizing source code paths to /src across multiple images, generalizing file inclusion patterns, and updating shell install workflows accordingly.

Flow diagram for normalized source code path during build

flowchart TD
  A["Git clone source code to /src"] --> B["Import /src into build images"]
  B --> C["Run install scripts from /src"]
  C --> D["Final image contains code from /src"]
Loading

File-Level Changes

Change Details Files
Normalize source code directory path to /src across images
  • Updated git add and import destinations from /app or root to /src directories
  • Adjusted shell git clone and cd commands to use /src/<repo> paths
images/hooks/werf.inc.yaml
images/libvirt/werf.inc.yaml
images/dvcr/werf.inc.yaml
images/qemu/werf.inc.yaml
images/virt-artifact/werf.inc.yaml
Generalize stageDependencies patterns in hooks image
  • Replaced explicit go.mod, go.sum, and **/*.go entries with a catch-all **/* pattern for install and setup stages
images/hooks/werf.inc.yaml
Update shell install steps to initialize and switch to /src
  • Added mkdir -p /src before cloning distribution in dvcr image
  • Inserted cd /src in the shell install stage of hooks image
images/dvcr/werf.inc.yaml
images/hooks/werf.inc.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@alexey-gavrilov-flant alexey-gavrilov-flant self-assigned this Oct 9, 2025
@alexey-gavrilov-flant alexey-gavrilov-flant added this to the v1.2.0 milestone Oct 9, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location> `images/hooks/werf.inc.yaml:10` </location>
<code_context>
-    - go.sum
-    setup:
-    - "**/*.go"
+    - "**/*"
 - add: {{ .ModuleDir }}/images/virtualization-artifact
-  to: /app/images/virtualization-artifact
</code_context>

<issue_to_address>
**suggestion (performance):** Broadening stageDependencies to all files may introduce unnecessary rebuilds.

Using "**/*" will trigger rebuilds for any file change, including non-source files, which may slow down builds and reduce cache efficiency. Consider if a narrower pattern would be more appropriate.

Suggested implementation:

```
  stageDependencies:
    install:
    - "**/*.go"
    - go.sum

```

```
  stageDependencies:
    install:
      - "**/*.go"
      - go.sum

```
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

- go.sum
setup:
- "**/*.go"
- "**/*"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (performance): Broadening stageDependencies to all files may introduce unnecessary rebuilds.

Using "**/*" will trigger rebuilds for any file change, including non-source files, which may slow down builds and reduce cache efficiency. Consider if a narrower pattern would be more appropriate.

Suggested implementation:

  stageDependencies:
    install:
    - "**/*.go"
    - go.sum

  stageDependencies:
    install:
      - "**/*.go"
      - go.sum

@universal-itengineer universal-itengineer merged commit 1a025d0 into main Oct 10, 2025
30 of 32 checks passed
@universal-itengineer universal-itengineer deleted the src-fixed-main branch October 10, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants