Skip to content

Conversation

eofff
Copy link
Contributor

@eofff eofff commented Oct 9, 2025

Description

Add d8_virtualization_virtualmachinesnapshot_info and d8_virtualization_virtualdisksnapshot_info prometheus metrics.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: observability
type: feature
summary: Add snapshots info prometheus metrics.

Copy link

sourcery-ai bot commented Oct 9, 2025

Reviewer's Guide

This PR enhances the virtual machine snapshot monitoring by adding a new ‘virtualmachinesnapshot_info_virtualmachine’ metric, integrating it into the data model, metric registry, and scraper implementation.

Class diagram for updated dataMetric structure

classDiagram
class dataMetric {
  string Name
  string Namespace
  string UID
  v1alpha2.VirtualMachineSnapshotPhase Phase
  string VirtualMachine
}
Loading

Class diagram for updated scraper methods

classDiagram
class scraper {
  Report(m *dataMetric)
  updateMetricVMSnapshotStatusPhase(m *dataMetric)
  updateMetricVMSnapshotVM(m *dataMetric)
  defaultUpdate(descName string, value float64, m *dataMetric, labels ...string)
}
Loading

File-Level Changes

Change Details Files
Extend dataMetric to include the associated VirtualMachine name
  • Added a VirtualMachine field to dataMetric struct
  • Populated VirtualMachine from vms.Spec.VirtualMachineName in newDataMetric
data_metric.go
Define and register new MetricVMSnapshotInfoVirtualMachine
  • Introduced MetricVMSnapshotInfoVirtualMachine constant
  • Added new MetricInfo entry in vmsnapshotMetrics map
metrics.go
Update scraper to emit the new VM info metric
  • Called updateMetricVMSnapshotVM in scraper.Report
  • Implemented updateMetricVMSnapshotVM invoking defaultUpdate with VM label
scraper.go

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@eofff eofff added this to the v1.2.0 milestone Oct 9, 2025
@eofff eofff changed the title vm feat(observability): add d8_virtualization_virtualmachinesnapshot_info and d8_virtualization_virtualdisksnapshot_info prometheus metrics Oct 9, 2025
@eofff eofff added e2e/run Run e2e test on cluster of PR author and removed e2e/run Run e2e test on cluster of PR author labels Oct 9, 2025
@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Oct 9, 2025
Signed-off-by: Valeriy Khorunzhin <[email protected]>
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Oct 9, 2025

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: cancelled.

@eofff eofff force-pushed the feat/api/add-vm-and-vd-snapshots-vd-and-vm-metrics branch 3 times, most recently from ece7b3a to 7e7b585 Compare October 9, 2025 15:25
@eofff eofff added the e2e/run Run e2e test on cluster of PR author label Oct 9, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Oct 9, 2025

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants