Skip to content

adds dictionary_learning converters#477

Draft
anthonyduong9 wants to merge 2 commits intomainfrom
add-dictionary_learning-converters
Draft

adds dictionary_learning converters#477
anthonyduong9 wants to merge 2 commits intomainfrom
add-dictionary_learning-converters

Conversation

@anthonyduong9
Copy link
Copy Markdown
Collaborator

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • I have not rewritten tests relating to key interfaces which would affect backward compatibility

You have tested formatting, typing and tests

  • I have run make check-ci to check format and linting. (you can run make format to format code if needed.)

Performance Check.

If you have implemented a training change, please indicate precisely how performance changes with respect to the following metrics:

  • L0
  • CE Loss
  • MSE Loss
  • Feature Dashboard Interpretability

Please links to wandb dashboards with a control and test group.

@anthonyduong9 anthonyduong9 force-pushed the add-sparsify-converter branch from 3cadaf9 to 305e565 Compare May 12, 2025 15:35
@anthonyduong9 anthonyduong9 force-pushed the add-sparsify-converter branch from bbcb3a4 to b124d01 Compare July 12, 2025 20:19
Base automatically changed from add-sparsify-converter to main July 12, 2025 20:44
@anthonyduong9 anthonyduong9 force-pushed the add-dictionary_learning-converters branch from 43c591f to 84c4d79 Compare July 12, 2025 20:54
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 12, 2025

Codecov Report

Attention: Patch coverage is 6.15385% with 61 lines in your changes missing coverage. Please review.

Project coverage is 73.48%. Comparing base (976aa4b) to head (84c4d79).

Files with missing lines Patch % Lines
sae_lens/toolkit/pretrained_sae_loaders.py 6.15% 61 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #477      +/-   ##
==========================================
- Coverage   74.84%   73.48%   -1.36%     
==========================================
  Files          19       19              
  Lines        3224     3289      +65     
  Branches      467      479      +12     
==========================================
+ Hits         2413     2417       +4     
- Misses        645      706      +61     
  Partials      166      166              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant