fix: resolve connection leaks, pending request tracking, and infinite combo loops#2676
Open
pandamoon21 wants to merge 2 commits into
Open
fix: resolve connection leaks, pending request tracking, and infinite combo loops#2676pandamoon21 wants to merge 2 commits into
pandamoon21 wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
This PR fixes three request-handling stability issues:
Fix
AbortSignalthrough the chat handling flow and wire it into the stream controller disconnect/abort path.499responses immediately so they do not mark healthy accounts unavailable or trigger account fallback.onCompletecallback so successful streams decrement the pending request counter immediately.400 Bad Requestwhen a circular combo reference is detected.Regression coverage
400 Bad Requestresponse for circular combo referencesVerification
npx eslint "src/sse/handlers/chat.js" "tests/unit/chat-client-abort-fallback.test.js"— passedcd tests && npx vitest run unit/chat-client-abort-fallback.test.js unit/combo-routing.test.js unit/combo-fusion.test.js unit/gemini-native-endpoint.test.js unit/headroom-chat-core.test.js— 28/28 passedgit diff --check— passed