fix(minimax): normalize unsigned thinking block starts#2706
Open
rixzkiye wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
signaturefield when MiniMax omits it from Anthropicthinkingblock-start eventsminimaxandminimax-cnsignature_deltaevents unchangedProblem
MiniMax can stream an Anthropic event shaped like:
{ "type": "content_block_start", "content_block": { "type": "thinking", "thinking": "" } }Strict Messages clients deserialize
signatureon the block-start event before a latersignature_deltaarrives. Grok Build therefore aborts the turn with:Anthropic-style thinking block starts use an empty signature placeholder; this PR adds only that missing envelope field. It does not synthesize or replace the provider signature.
Verification
undefinedcd tests && npx vitest run unit/minimax-thinking-signature.test.js unit/openai-responses-terminal-event.test.js unit/reasoningContentInjector.test.js unit/openai-to-claude-tools-no-type.test.js— 27 tests passedsignature_deltaminimax/MiniMax-M3: Claude-to-Claude streaming completed successfully with thinking enabled and 26 toolsRelated
Companion transport/body alignment fix: #2705. No existing issue matching the client-side missing-signature serialization error was found.