fix(kiro): map GPT-5.6 reasoning effort fields#2707
Open
SemonCat wants to merge 2 commits into
Open
Conversation
Preserve Responses API effort through the OpenAI bridge and emit Kiro's schema-specific GPT reasoning fields without legacy prompt tags. Keep Claude adaptive effort behavior and legacy-model guards intact.
Use the native GPT effort parser to decide whether legacy thinking tags should be suppressed, while keeping explicit disable sentinels off.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reasoning.effortmapping through the complete Responses-to-Kiro flowreasoning.effortthrough the OpenAI intermediatethinkingplusoutput_config.effortbehavior and legacy-model guardsWhy
Kiro's effort path is model-schema-specific: GPT models use
reasoning.effort, while Claude models useoutput_config.effort.This is a follow-up to #2701, which established the core GPT-5.6 structured effort mapping and was confirmed merged by the maintainer. This PR carries that flow through the actual Hermes
codex_responsespath and tightens the remaining edge cases.The remaining gap after #2701 is end-to-end transport: the standard Responses API
reasoning.effortis removed during Responses-to-OpenAI conversion unless it is copied into the OpenAI intermediate first. The base flow can also emit legacy thinking tags alongside the native GPT field and normalizexhigh/maxtoo aggressively. This follow-up addresses those cases while preserving the older fallback behavior for unsupported values.Official Kiro effort documentation: https://kiro.dev/docs/cli/chat/effort/
Resulting behavior
low,medium,high, andxhighuse the nativereasoning.effortfield.maxmaps to GPT wire valuexhigh.auto,minimal, andultraretain the legacy thinking fallback.none,off, anddisabledremain intentionally disabled.thinkingplusoutput_config.effort.Verification
npm run buildgit diff --checkTHINK:high/THINK:mediumwith the fix(kiro): map GPT-5.6 reasoning effort fields #2707 patch stackRepository-wide lint and the broad translator snapshot suite contain unrelated upstream baseline failures; the focused suite covers the changed request paths and fallback semantics.