fix(kiro): validate terminal streams before emitting output#2717
Closed
SemonCat wants to merge 2 commits into
Closed
fix(kiro): validate terminal streams before emitting output#2717SemonCat wants to merge 2 commits into
SemonCat wants to merge 2 commits into
Conversation
Owner
|
Thanks @SemonCat for the contribution! Reviewed and merged into master. 🙏 |
Contributor
Author
|
Follow-up pushed in 966c6dc: all response-semantic heuristics were removed. The branch is now strictly EventStream / terminal integrity; answer completeness stays in the caller layer. Focused Kiro suites (75 tests) and the production build pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Kiro responses without a trustworthy terminal boundary could be normalized into
finish_reason=stop. The fix buffers the bounded upstream response, validates its transport and terminal structure, and only then emits it downstream.Scope
This PR is intentionally transport-only. It does not inspect answer wording, ellipses, progress language, task completeness, or any other semantic policy. Semantic completion belongs in the caller/agent layer.
Verification
node --check open-sse/executors/kiro.js: passedgit diff --check: passed