Standardize on "mixingEnabled" and explain --mixing config more thoroughly. #2440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jholdstock
force-pushed
the
enablemixing
branch
from
87aa050 to
82ce72c
Compare
jholdstock
changed the title
|
Needs rebase. As is this won't compile. There are additional DisableMixing wallet.Config fields used by the loader on master. |
Loader was using a flag to disable mixing whereas the rest of the code was using a flag to enable it. Standardizing on one removes the need to invert back and forth.
jholdstock
force-pushed
the
enablemixing
branch
from
82ce72c to
187af7d
Compare
jrick
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loader was using a flag to disable mixing whereas the rest of the code was using a flag to enable it. Standardizing on one removes the need to invert back and forth.