Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images can be losslessly shrunk #2118

Open
2 tasks
fulldecent opened this issue May 19, 2019 · 2 comments
Open
2 tasks

Images can be losslessly shrunk #2118

fulldecent opened this issue May 19, 2019 · 2 comments

Comments

@fulldecent
Copy link
Contributor

fulldecent commented May 19, 2019

Most/all of the images in the app can be losslessly shrunk. This means they can be encoded better and still have pixel-for-pixel parity with what is currently in this repository.

That saves megabytes off of the final application size.

Solving this issue permanently requires to add a script to package.json which will optimize vector images (SVGs) and possibly raster images. This could be implemented as a test case -- test passes if all SVG = optimized(SVG).

Work plan

  • Find a suitable SVG optimizer, like https://www.npmjs.com/package/svgo and find the right command line or a small script which optimizes an SVG
  • Integrate this into the test scripts

Follow on work

After the above, if there is additional scope available to optimize raster images then we can use a different approach. This is because raster optimization is much slower.

fulldecent added a commit to fulldecent/decrediton that referenced this issue May 19, 2019
fulldecent added a commit to fulldecent/decrediton that referenced this issue May 19, 2019
@ta-lind
Copy link
Member

ta-lind commented May 20, 2019

Noticed it's only addressing the DCR symbol? If the context allows, that too could be as a vector format – svg.

@fulldecent
Copy link
Contributor Author

Here are a list of image optimizers that ImageOptim uses. They are all open source

Screen Shot 2019-05-23 at 15 17 39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants