Losslessly compress bitmap images #2126
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusd
approved these changes
May 23, 2019
|
nACK. Appreciate the PR, but @matheusd and I discussed things a bit and would prefer if you would use a package such as https://www.npmjs.com/package/imagemin and include a script in package.json to have repeatable and verifiable image minification. Same goes for the PR concering the SVGs as well. |
|
This PR is not that. What you are talking about is harder and that is in scope at #2118 If this PR adds any value it can be merged. Otherwise it can be abandoned. The result of #2118 will be to produce this PR, and to produce it repeatably. But that issue is harder and not available today whereas this PR is available today. |
|
OK fair enough, closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created using https://imageoptim.com/mac
Replaces PR #2120