Skip to content

Minor cleanups for new helpers. #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 28, 2022
Merged

Minor cleanups for new helpers. #337

merged 5 commits into from
Mar 28, 2022

Conversation

jholdstock
Copy link
Member

@jholdstock jholdstock commented Mar 28, 2022 •
edited
Loading

Following #329

  • Ensure errors are properly wrapped with %w
  • Error strings should not starts with caps.
  • Add missing params to "Bad signature" error log

Following #333

  • Move database encoding helpers.

And

  • Critical log startup and shutdown - these messages should always be logged, even if log level is set to WARN or ERROR.

@jholdstock
Minor cleanups for new helpers.
093e03f 
- Ensure errors are properly wrapped with `%w`
- Error strings should not starts with caps.
- Add missing params to "Bad signature" error log
@jholdstock
Move database encoding helpers.
9e8044d
@jholdstock
Critical log startup and shutdown.
2a45363 
These messages should always be logged, even if log level is set to WARN or ERROR.
@jholdstock
Use time.After instead of tickers.
47d69a3
@jholdstock jholdstock merged commit a412e3e into decred:master Mar 28, 2022
@jholdstock jholdstock deleted the minor-cleaning branch September 20, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dajohi dajohi dajohi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jholdstock @dajohi