Fix the roster ID generation #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sorts the service identities because it can happen the order array change when writing/reading toml files. This makes sure it doesn't impact the final ID.
|
It would be necessary to increase the patch version to use the fix in cothority |
|
Can you explain the backwards compatibility impacts of this again better in your comment above? |
jeffallen
reviewed
Mar 19, 2019
This adds a function to generate the correct ID of the roster. This should eventually be the way to know the ID as we can't compute it from the list of server identities.
|
So the first backwards compatibility was a bit shaky because the ID is usually transferred through protobuf so you don't recalculate it. But when you derive the roster you do. The order is not supposed to have changed because it happens when you read/write toml files, that's why we never had this issue. But to have 100% certainty of backwards compatibility, I updated the code so that we can gradually use the fix. |
jeffallen
approved these changes
Mar 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sorts the service identities because it can happen the order
array change when writing/reading toml files. This makes sure it
doesn't impact the final ID.
This issue occurs when checking the roster sent back when creating a genesis block in dedis/cothority#1764