Open
Conversation
avishkar58
reviewed
Apr 3, 2023
Contributor
avishkar58
left a comment
avishkar58
left a comment
There was a problem hiding this comment.
This is really well done, thank you Shreya!!
| if current_user.is_event_admin(event_id): | ||
| responses = response_repository.get_all_for_event(event_id, not include_unsubmitted) | ||
|
|
||
| elif current_user.is_action_editor(event_id): |
Contributor
There was a problem hiding this comment.
I wonder if there's a better name than "action-editor" that's not a journal-specific term, since the functionality is not limited to a journal event type. Will try think of something too!
Collaborator
Author
There was a problem hiding this comment.
I agree! I was thinking something along the lines of evaluator, critic, etc. What do you think?
Contributor
|
Will approve once you've added the tests for action editor permissions :) |
added 2 commits
April 4, 2023 08:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a view for users who are an action editor for a particular event. They are able to view the responses that they were assigned to and assign reviewers to a response.
(Still need to add tests for action editor permissions)