Skip to content
This repository was archived by the owner on Apr 3, 2024. It is now read-only.

Conversation

@OzNetNerd
Copy link

No description provided.

@OzNetNerd OzNetNerd closed this Aug 12, 2019
@OzNetNerd OzNetNerd reopened this Aug 12, 2019
@glb
Copy link
Contributor

glb commented Aug 12, 2019

Thanks for the contribution @OzNetNerd ! A couple of things:

  1. I think what you're intending this to do is to have the limit parameter operate on the list operation as a whole, which on reflection makes more sense than what it's currently doing, which is setting the page size using the API's limit query parameter. However, it's not really properly doing that. What it should be doing instead is keeping track of how many items have been yielded and stopping the loop after limit items have been produced. Make sense?
  2. Could you please re-word the commit message to fix the typo? It will make searching history easier for future folks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants