Apply cve-2025-nov patch series #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Bump SBAT 'grub' entry to 6 - Set DPKG_VENDOR to Deepin, SB_EFI_VENDOR to deepin
Reviewer's guide (collapsed on small PRs)Reviewer's GuideApplies the November 2025 CVE patch set to grub, wires the new patches into the Debian packaging, and updates SBAT/packaging metadata for the Deepin vendor, including bumping the grub SBAT generation to 6. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
TAG Bot TAG: 2.12-7deepin7 |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Since you’ve bumped the SBAT generation and added multiple
*.csv.invariants, double-check that the grub SBAT level and component names are kept consistent acrossdebian/sbat.debian.csv.in,sbat.deepin.csv.in, andsbat.uos.csv.into avoid mismatched revocations between vendors. - The introduction of
DPKG_VENDORandSB_EFI_VENDORfor Deepin builds indebian/rulesshould be guarded so it doesn’t affect non-Deepin derivatives; consider scoping or conditioning these variables so they only apply when building for that specific vendor.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since you’ve bumped the SBAT generation and added multiple `*.csv.in` variants, double-check that the grub SBAT level and component names are kept consistent across `debian/sbat.debian.csv.in`, `sbat.deepin.csv.in`, and `sbat.uos.csv.in` to avoid mismatched revocations between vendors.
- The introduction of `DPKG_VENDOR` and `SB_EFI_VENDOR` for Deepin builds in `debian/rules` should be guarded so it doesn’t affect non-Deepin derivatives; consider scoping or conditioning these variables so they only apply when building for that specific vendor.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/integrate |
|
AutoIntegrationPr Bot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Apply November 2025 CVE patch set to grub and update Debian packaging metadata accordingly.
Bug Fixes:
Enhancements:
Build: