Skip to content

Conversation

@luojiahao11
Copy link
Contributor

@luojiahao11 luojiahao11 commented Jun 9, 2025

var/run/utmp don't be updated after logout

Summary by Sourcery

Enable utmp file updates upon user logout to resolve login failures, and update the Debian packaging accordingly.

Bug Fixes:

  • Restore utmp writing on logout to ensure sessions are correctly recorded.

Build:

  • Update Debian changelog and patch for login to turn on utmp writing.

@sourcery-ai
Copy link

sourcery-ai bot commented Jun 9, 2025

Reviewer's Guide

This PR re-enables updates to the utmp file on logout by updating the Debian packaging patch and its changelog entry to ensure correct utmp writing behavior.

File-Level Changes

Change Details Files
Update Debian changelog for utmp writing fix
  • Bump package version to include the new patch release
  • Add changelog entry summarizing the logout utmp update fix
  • Reference the updated patch file
debian/changelog
Modify patch to enable utmp writing on logout
  • Remove code that prevented utmp updates during logout
  • Insert a call to write the utmp record when a session ends
  • Ensure necessary utmp headers or symbols are included
debian/patches/debian/login-turn-on-utmp-writing.patch

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot deepin-ci-robot requested review from BLumia and myml June 9, 2025 01:42
@github-actions
Copy link

github-actions bot commented Jun 9, 2025

TAG Bot

TAG: 2.40.4-3deepin6
EXISTED: no
DISTRIBUTION: unstable

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @luojiahao11 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@luojiahao11 luojiahao11 closed this Jun 9, 2025
@luojiahao11 luojiahao11 reopened this Jun 9, 2025
@hudeng-go
Copy link
Contributor

/retest

@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aaronUniontech, hudeng-go

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot deepin-ci-robot merged commit 51d56c2 into deepin-community:master Jun 9, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants