Skip to content

Conversation

@wxphaha
Copy link

@wxphaha wxphaha commented Jun 19, 2025

revert var/run/utmp don't be updated after logout/login
Bug: 305567

Summary by Sourcery

Revert the Debian utmp-writing patch to restore proper utmp updates on logout/login and introduce a new UnionTech patch to correct ARM CPU model name detection in lscpu.

Bug Fixes:

  • Revert the login-turn-on-utmp-writing Debian patch to ensure /var/run/utmp is updated after user logout/login.
  • Add uniontech-fix-arm-lscpu-modename patch to fix incorrect CPU model name reporting on ARM (Phytium) platforms.

     revert var/run/utmp don't be updated after logout/login
Bug: 305567
@sourcery-ai
Copy link

sourcery-ai bot commented Jun 19, 2025

Reviewer's Guide

This PR updates the Debian packaging by bumping the package revision in the changelog, removing an obsolete utmp-writing patch, and introducing a new ARM CPU model name fix for lscpu, with the patches series updated accordingly.

File-Level Changes

Change Details Files
Update Debian package version and changelog for the new patch
  • Incremented upstream version in debian/changelog
  • Documented Bug 305567
  • Referenced the new uniontech-fix-arm-lscpu-modename.patch
debian/changelog
Replace obsolete utmp-writing patch with ARM lscpu modename fix
  • Removed login-turn-on-utmp-writing.patch
  • Added uniontech-fix-arm-lscpu-modename.patch
  • Updated debian/patches/series to reflect these changes
debian/patches/series
debian/patches/uniontech-fix-arm-lscpu-modename.patch
debian/patches/debian/login-turn-on-utmp-writing.patch

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot deepin-ci-robot requested a review from BLumia June 19, 2025 10:01
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zccrs for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link
Contributor

Hi @wxphaha. Thanks for your PR.

I'm waiting for a deepin-community member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

TAG Bot

TAG: 2.40.4-3deepin8
EXISTED: no
DISTRIBUTION: unstable

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @wxphaha - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Zeno-sole Zeno-sole merged commit 2c9afcf into deepin-community:master Jun 19, 2025
1 of 2 checks passed
@wxphaha wxphaha deleted the fix-arm-lscpu branch June 19, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants