Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] disable and delete workflows that are no longer in use #2753

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

siddvenk
Copy link
Contributor

@siddvenk siddvenk commented Mar 4, 2025

Description

This PR deletes the following workflows:

  • benchmark-nightly
  • instant-benchmark

There are other standard tools we use for benchmarking, and those are no longer needed.

Additionally, it disables the cron trigger for the following:

  • lmi-no-code
  • p4d optimizations test
  • nightly-docker-sync-ecr

It leaves the actual tests in place for those workflows - I will take a look and validate whether any required tests are missing from the integration test suite, which is where all our tests should live. We do not monitor those tests

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • Please add the link of Integration Tests Executor run with related tests.
  • Have you manually built the docker image and verify the change?
  • Have you run related tests? Check how to set up the test environment here; One example would be pytest tests.py -k "TestCorrectnessLmiDist" -m "lmi_dist"
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A
    Logs for Test A

  • Test B
    Logs for Test B

@siddvenk siddvenk requested review from zachgk and a team as code owners March 4, 2025 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant