Skip to content

Conversation

@xyang16
Copy link
Contributor

@xyang16 xyang16 commented Sep 26, 2025

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • Please add the link of Integration Tests Executor run with related tests.
  • Have you manually built the docker image and verify the change?
  • Have you run related tests? Check how to set up the test environment here; One example would be pytest tests.py -k "TestCorrectnessLmiDist" -m "lmi_dist"
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A
    Logs for Test A

  • Test B
    Logs for Test B

@xyang16 xyang16 requested review from a team and zachgk as code owners September 26, 2025 03:50
@frankfliu
Copy link
Contributor

@xyang16 This seems a flaky test on windows.

@xyang16 xyang16 merged commit ef110ab into deepjavalibrary:master Oct 20, 2025
8 of 9 checks passed
ksuma2109 pushed a commit that referenced this pull request Oct 21, 2025
@xyang16 xyang16 deleted the zip branch October 23, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants