-
Notifications
You must be signed in to change notification settings - Fork 575
fix(finetune): calculate fitting stat when using random fitting in finetuning process #4928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Chengqian-Zhang
wants to merge
12
commits into
deepmodeling:devel
Choose a base branch
from
Chengqian-Zhang:0826_finetune_fparam
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
0f91fe0
Init branch
Chengqian-Zhang 316a6af
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 1f8d368
Merge branch 'devel' into 0826_finetune_fparam
Chengqian-Zhang 2fbe51c
Move compute_fitting_stat to dp_atomic_model
Chengqian-Zhang 939558f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 003233f
Change UT to detech this error
Chengqian-Zhang 4241d51
Add pd support
Chengqian-Zhang 12b0136
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 59c50c8
Recover fparam.npy
Chengqian-Zhang 646977c
Update doc
Chengqian-Zhang 52d29ef
Fix typo
Chengqian-Zhang 5ebd7e3
Merge branch 'devel' into 0826_finetune_fparam
Chengqian-Zhang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -493,6 +493,24 @@ def change_out_bias( | |||||
| else: | ||||||
| raise RuntimeError("Unknown bias_adjust_mode mode: " + bias_adjust_mode) | ||||||
|
|
||||||
| def compute_fitting_stat( | ||||||
| self, | ||||||
| sample_merged: Union[Callable[[], list[dict]], list[dict]], | ||||||
| ) -> None: | ||||||
| """Compute the input statistics (e.g. mean and stddev) for the fittings from packed data. | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
|
||||||
| Parameters | ||||||
| ---------- | ||||||
| sample_merged : Union[Callable[[], list[dict]], list[dict]] | ||||||
| - list[dict]: A list of data samples from various data systems. | ||||||
| Each element, `merged[i]`, is a data dictionary containing `keys`: `torch.Tensor` | ||||||
| originating from the `i`-th data system. | ||||||
| - Callable[[], list[dict]]: A lazy function that returns data samples in the above format | ||||||
| only when needed. Since the sampling process can be slow and memory-intensive, | ||||||
| the lazy function helps by only sampling once. | ||||||
| """ | ||||||
| pass | ||||||
|
|
||||||
| def _get_forward_wrapper_func(self) -> Callable[..., torch.Tensor]: | ||||||
| """Get a forward wrapper of the atomic model for output bias calculation.""" | ||||||
|
|
||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend changing the method name to
compute_fitting_input_stat.