-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API and CLI command for updating multiple indexes at one #4
Conversation
Trivy scanning results. |
Code Coverage Summary
Diff against main
Results for commit: 114494f Minimum allowed coverage is ♻️ This comment has been updated with latest results |
ac10de6
to
f3842b3
Compare
f3842b3
to
58df9e2
Compare
58df9e2
to
114494f
Compare
await similarity_index.update() | ||
``` | ||
|
||
### Detect Similarity Indexes in Views |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it would be beneficial to add extra method on collection to update all indexes used inside? Something like Collection.update_indexes() which aggregates all SimilarityIndexes and executes update on them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe. I viewed the CLI as the primary method of updating collections, and focused less on ways of doing this in code that can't be used by CLI, but you may be right. On the other hand this seems like a separate area, so how about we open a new ticket and do this in a new PR?
No description provided.